-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable post-start functions that are done in snc #4560
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
the required `growpart` and `xfs_growfs` commands are run as a systemd service which is part of the self-sufficient bundle for microshift preset this is handled by crc like before
since the dnsmasq config is added by a systemd service in the self-sufficient bundle we can remove the code from crc
this removes code adding the pull-secret to the cluster using `oc`, instead it copies the pull secret file to /opt/crc/crc-pullsecret which is then used by a systemd service in the bundle to add the pull secret to the cluster for both the openshift and microshift presets
this copies the generated kubeadmin and developer user passwords to `/opt/crc/` which is then used by a systemd service and modifies the needed ocp resources
this is done via a systemd service on the bundle which automatically starts the routes controller pod after the cluster is started
this is done by a systemd service in the bundle so the code on crc can be removed
this removes the code patching the configmap admin-kubeconfig-client-ca to use the custom CA, instead it copies the generated CA to '/opt/crc/' which is then used by a systemd service to created the required secret and updates the configmap
@anjannath: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
This removes code doing the various post-start cluster provisioning tasks which are moved to the self sufficient bundle as part of PR crc-org/snc#980
Relates to: crc-org/snc#638
Type of change
test, version modification, documentation, etc.)
Testing
crc start
should be successful when using the bundle from [wip] add systemd services for configuration after start snc#980 (linux and windows bundle can be downloaded from the opensift CI artifacts https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/crc-org_snc/980/pull-ci-crc-org-snc-master-e2e-snc/1876969244206305280/)crc start
should also succeed when using the current released bundle (4.17.0 or 4.17.10)Contribution Checklist